Merged
Conversation
🦋 Changeset detectedLatest commit: 705951c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
commented
Apr 27, 2022
internal/transform/transform_test.go
Outdated
Comment on lines
+210
to
+439
| name: "basic", | ||
| source: `<div>Hello world!</div>`, | ||
| want: `<div data-astro-source-file="/test.astro">Hello world!</div>`, |
Member
Author
There was a problem hiding this comment.
We inject data-astro-source-file={transformOpts.Pathname} to any elements.
Comment on lines
+215
to
+490
| name: "no components", | ||
| source: `<Component>Hello world!</Component>`, | ||
| want: `<Component>Hello world!</Component>`, |
internal/transform/transform_test.go
Outdated
Comment on lines
+220
to
+449
| name: "injects root", | ||
| source: `<html></html>`, | ||
| want: `<html data-astro-source-root="file://"></html>`, |
Member
Author
There was a problem hiding this comment.
We inject data-astro-source-root={transformOpts.ProjectRoot} to the html element
internal/transform/transform.go
Outdated
| ProjectRoot string | ||
| PreprocessStyle interface{} | ||
| StaticExtraction bool | ||
| AnnotateSourceFile bool |
Member
Author
There was a problem hiding this comment.
This is a new annotateSourceFile: boolean option for the compiler
9fe1c45 to
f19c778
Compare
f19c778 to
92288f7
Compare
92288f7 to
4924894
Compare
4924894 to
87b13d4
Compare
c63fc41 to
49058cb
Compare
Member
|
Tested it with withastro/astro#9016, and it works! |
ematipico
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A