fix: preserve explicit html and head tags when JSX comment follows DOCTYPE#1134
Merged
Princesseuh merged 2 commits intowithastro:mainfrom Feb 17, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 2b1dc8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d967dd6 to
b7487e9
Compare
…CTYPE (withastro#1124) When a JSX comment like `{/* Comment */}` appeared between DOCTYPE and the `<html>` tag, the explicit `<html>` and `<head>` tags were removed from output. Root cause: - The expression triggered implicit `<html>` and `<head>` insertion with `ImplicitNodeMarker` attribute - When explicit tags came later, the marker wasn't removed - Printer skips outputting tags with `ImplicitNodeMarker` Changes: - Add `removeImplicitMarker` helper function - Handle `<html>` tag before `originalIM` check in `inBodyIM` to prevent implicit `<head>` from being converted to `<body>` - Remove `ImplicitNodeMarker` when explicit `<html>` or `<head>` is encountered
b7487e9 to
8a75ecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
<html>and<head>tags were removed from output when a JSX comment appeared between DOCTYPE and the<html>tagremoveImplicitMarkerhelper function to removeImplicitNodeMarkerattribute from nodesinBodyIMto handle<html>tag before theoriginalIMcheck, preventing implicit<head>from being converted to<body>inHeadIMto copy attributes and removeImplicitNodeMarkerwhen explicit<head>tag is encounteredCloses #1124
Testing
TestPrinterandTestPrintToJSONgo test ./internal/...Docs
Bug fix only - no documentation changes needed.