Fix expression parsing in foreign context#1062
Merged
ematipico merged 3 commits intowithastro:mainfrom Feb 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: a30bd42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MoustaphaDev
approved these changes
Feb 4, 2025
Member
MoustaphaDev
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fix!
ematipico
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
<image />elements inside an<svg>ends up with<img />outside #1063This PR adds the current
Namespaceto the expression Node.When writing an expression inside foreign content (i.e. SVG) the astro compiler did not persist the namespace and therefore parsed the contained nodes in normal HTML mode. This lead to
<image>tags incorrectly being transformed to<img>tags, but could also have caused other Problems.Testing
{<image />}inside svgDocs
bug fix only