Skip to content

fix(routing): trailingSlash on endpoints#9597

Merged
ematipico merged 4 commits intowithastro:mainfrom
lilnasy:fix/9206
Jan 4, 2024
Merged

fix(routing): trailingSlash on endpoints#9597
ematipico merged 4 commits intowithastro:mainfrom
lilnasy:fix/9206

Conversation

@lilnasy
Copy link
Copy Markdown
Contributor

@lilnasy lilnasy commented Jan 3, 2024

Changes

Testing

Added a unit test.
image

Docs

Does not affect behavior.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: e0374e8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Jan 3, 2024
@lilnasy lilnasy marked this pull request as ready for review January 3, 2024 20:14
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🙏

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
@kripod
Copy link
Copy Markdown

kripod commented Feb 17, 2024

Thanks for enforcing this.

Unfortunately, the change breaks Static File Endpoints in development as I reported here: #10149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Route always returns 404 on Vercel depending on trailingSlash

4 participants