feat: add extendable CSSProperties interface#9587
Merged
Princesseuh merged 2 commits intowithastro:mainfrom Jan 3, 2024
Merged
feat: add extendable CSSProperties interface#9587Princesseuh merged 2 commits intowithastro:mainfrom
CSSProperties interface#9587Princesseuh merged 2 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 4976390 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
98a96b2 to
9f82757
Compare
9f82757 to
f09a7ed
Compare
Princesseuh
approved these changes
Jan 3, 2024
Member
Princesseuh
left a comment
There was a problem hiding this comment.
Thank you! This is awesome.
bluwy
approved these changes
Jan 3, 2024
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
CSSPropertiesinterface to thestyleattribute that consumers can extend to add their own custom properties. This matches the approach from other frameworks, e.g React and SolidJS.Testing
I can't seem to find tests for the types, but please do point me in the right direction if they exist somewhere.
CleanShot.2024-01-03.at.00.44.49.mp4
Docs
withastro/docs#6062
/cc @withastro/maintainers-docs for feedback!