Conversation
🦋 Changeset detectedLatest commit: 0e1b539 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
reviewed
Jan 2, 2024
ematipico
approved these changes
Jan 2, 2024
Member
|
We should probably double-check with @withastro/maintainers-docs, however, the PR is fine with me! |
sarah11918
reviewed
Jan 2, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
🍼 suggestion, @bluwy! Thanks for adding this!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
close #8192
Supports passing a url string to
server.openand--opento open a specific URL in the browser on dev startup.Testing
Tested manually with the basic example. e.g.
pnpm dev --open /testDocs
Updated the JSDoc for
server.open.Might need to also update: https://docs.astro.build/en/reference/cli-reference/#--open
server.openseems to not be documented, but probably should: https://docs.astro.build/en/reference/configuration-reference/#server-options (Fixed by adding a missing@docsjsdoc tag)