Skip to content

Error on preview if outDir missing#9544

Merged
ematipico merged 5 commits intomainfrom
preview-error-missing
Jan 3, 2024
Merged

Error on preview if outDir missing#9544
ematipico merged 5 commits intomainfrom
preview-error-missing

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Dec 29, 2023

Changes

close #9297

When running the preview server, and the outDir is empty (forgot to build the app), error and exit.

image

Testing

Tested manually in the screenshot above.

Docs

n/a. I think it's a small qol feature that doesn't need documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 90a6062

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 29, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Invalid command. Expected: "/preview "

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Dec 29, 2023
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@Princesseuh Princesseuh added this to the 4.1.0 milestone Jan 2, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick thought for the changeset message!

bluwy and others added 2 commits January 3, 2024 15:55
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs is happy!

@ematipico ematipico merged commit b8a6fa8 into main Jan 3, 2024
@ematipico ematipico deleted the preview-error-missing branch January 3, 2024 13:05
@astrobot-houston astrobot-houston mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

astro preview fails silently with missing dist folder

4 participants