feat: export JSX types from jsx-runtime#9501
Merged
Princesseuh merged 4 commits intomainfrom Dec 23, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: e7d566c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
commented
Dec 22, 2023
| // can't import `astro-jsx` types inside the actual `jsx-runtime/index.js` file due to circular dependency issues. | ||
| import './astro-jsx.js'; | ||
| export * from './dist/jsx-runtime/index.js'; | ||
| export import JSX = astroHTML.JSX; |
Member
Author
There was a problem hiding this comment.
Yes, this is actual syntax that works. I had never seen that before yesterday
jasikpark
reviewed
Dec 22, 2023
Contributor
jasikpark
left a comment
There was a problem hiding this comment.
pretty, horrifying code. lgtm
bluwy
approved these changes
Dec 23, 2023
ematipico
approved these changes
Dec 23, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We're migrating our language-tooling to use JSX pragmas, but this require exporting
astroHTML.JSXasJSXfrom something namedjsx-runtimebecause it's hardcoded in TypeScript, very annoying, but nonetheless we can do that!For users on previous versions of Astro, our language server will fake this export until a majority of users are on whatever version this is released in.
Testing
N/A. Tested manually that it works in the language-server
Docs
N/A