Skip to content

feat(tailwind): create a tailwind.config.mjs file by default#8638

Merged
bluwy merged 9 commits intowithastro:mainfrom
florian-lefebvre:feat/tailwind-esm
Oct 9, 2023
Merged

feat(tailwind): create a tailwind.config.mjs file by default#8638
bluwy merged 9 commits intowithastro:mainfrom
florian-lefebvre:feat/tailwind-esm

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Changes

  • Since Astro is ESM only and that Tailwind supports ESM, default config file is now tailwind.config.mjs (instead of .cjs).

Testing

Not tested, I searched in the whole repo for tailwind.config occurences and updated relevant ones (eg. not in fixtures)

Docs

Updated the file extension in the docs

@florian-lefebvre florian-lefebvre requested a review from a team as a code owner September 22, 2023 14:55
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 682c740

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 22, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to docs! 🙌

Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited about this!

@delucis
Copy link
Copy Markdown
Member

delucis commented Oct 4, 2023

Noting that we should update Starlight’s docs to show .mjs and not .cjs once this is merged: https://starlight.astro.build/guides/css-and-tailwind/#tailwind-css

Potentially the same for the Fonts guide in Astro’s docs: https://docs.astro.build/en/guides/fonts/#register-fonts-in-tailwind (although that’s less directly impacted as it’s not showing Tailwind set-up in the same way).

@bluwy bluwy dismissed natemoo-re’s stale review October 9, 2023 14:21

Should be good now!

@bluwy bluwy merged commit 160d1cd into withastro:main Oct 9, 2023
@astrobot-houston astrobot-houston mentioned this pull request Oct 9, 2023
@florian-lefebvre florian-lefebvre deleted the feat/tailwind-esm branch October 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants