Skip to content

[docs] deprecate build.split and build.excludeMiddleware in config ref#8158

Merged
ematipico merged 2 commits intonextfrom
sarah11918-build-options-deprecated
Aug 21, 2023
Merged

[docs] deprecate build.split and build.excludeMiddleware in config ref#8158
ematipico merged 2 commits intonextfrom
sarah11918-build-options-deprecated

Conversation

@sarah11918
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 commented Aug 19, 2023 •
edited
Loading

…ference

Changes

Updates the configuration reference docs for the two build options being deprecated in favour of new adaptor config options.

  • removes @version (is that the right thing to do?) and adds the @deprecated tag
  • provides a short description that mentions the adaptor config that replaces it, links to the adapter reference page, and also links to our list of SSR adapter guides and suggests reading those for docs on the new config options.

Testing

No tests, and you must absolutely vet this syntax!

Docs

It's all docs!

@sarah11918 sarah11918 requested a review from a team as a code owner August 19, 2023 16:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 88b53b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 19, 2023
sarah11918
sarah11918 commented Aug 21, 2023
View reviewed changes
sarah11918
sarah11918 commented Aug 21, 2023
View reviewed changes
@ematipico ematipico merged commit d440521 into next Aug 21, 2023
@ematipico ematipico deleted the sarah11918-build-options-deprecated branch August 21, 2023 13:33
@sarah11918 sarah11918 mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarah11918 @matthewp @ematipico