Fix 404 response leading to an infinite loop when there is no 404 page#8136
Merged
natemoo-re merged 3 commits intowithastro:mainfrom Aug 18, 2023
Merged
Fix 404 response leading to an infinite loop when there is no 404 page#8136natemoo-re merged 3 commits intowithastro:mainfrom
natemoo-re merged 3 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 4fa7ef6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #8100
Checks if 404 route exists before calling
matchRoute.matchRoutewon't return undefined if the 404 route doesn't exist because we are in ssr. So we keep going through the recursion.Testing
Tested manually.
Docs
n/a