fix: dev server should redirect when a page doesn't exist#7841
Merged
fix: dev server should redirect when a page doesn't exist#7841
Conversation
🦋 Changeset detectedLatest commit: ebc69fc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
reviewed
Jul 27, 2023
Contributor
|
Missing a changeset. One nit comment, use your judgment on that one. |
Member
Author
|
@matthewp I changed the logic. There were few regressions while running tests. Now it should be fine. |
2227734 to
ebc69fc
Compare
bluwy
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #7752
Testing
I tested locally using a project. I tried to create a test, but the testing suite is not suitable for this case, it seems.
Docs
N/A