Skip to content

Update esbuild target for Deno#7687

Merged
bluwy merged 8 commits into
withastro:mainfrom
kwhinnery:deno-esbuild-target
Jul 24, 2023
Merged

Update esbuild target for Deno#7687
bluwy merged 8 commits into
withastro:mainfrom
kwhinnery:deno-esbuild-target

Conversation

@kwhinnery

@kwhinnery kwhinnery commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Changes

Updates the build target for esbuild from es2020 to esnext to allow for more advanced language features that are available in Deno.

Testing

Added a test that includes a language feature supported in esnext, in this case a top-level await.

Docs

This change doesn't require updates to the documentation - a Deno user would reasonably assume that all runtime features that work in Deno would work during the Astro build process as well.

@changeset-bot

changeset-bot Bot commented Jul 17, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7360ae0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Jul 17, 2023
@kwhinnery kwhinnery marked this pull request as ready for review July 18, 2023 14:06
@kwhinnery

Copy link
Copy Markdown
Contributor Author

There's a set of tests failing in an area of the code I didn't touch - are we seeing this on other PRs as well? Thanks!

@Princesseuh

Copy link
Copy Markdown
Member

There's a set of tests failing in an area of the code I didn't touch - are we seeing this on other PRs as well? Thanks!

Yep, sorry - my fault. We had a regression in our Markdoc integration. I went ahead and updated your branch.

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine as Deno 1.0 already supports many modern syntax from the start 🤔

@kwhinnery

Copy link
Copy Markdown
Contributor Author

Hey team! Any chance we could see this merged and shipped soon? Would love to update our template app.

@bluwy

bluwy commented Jul 24, 2023

Copy link
Copy Markdown
Member

I was hoping to get another eye on this from another maintainer, in case I miss something, but looks like it should be safe. Will merge this one.

@bluwy bluwy merged commit 0a1b333 into withastro:main Jul 24, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jul 24, 2023
@kwhinnery

Copy link
Copy Markdown
Contributor Author

Thanks a ton @bluwy!

@kwhinnery kwhinnery deleted the deno-esbuild-target branch July 25, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants