Fix [Object AsyncGenerator] logging for Markdoc components#7307
Merged
bholmesdev merged 3 commits intomainfrom Jun 6, 2023
Merged
Fix [Object AsyncGenerator] logging for Markdoc components#7307bholmesdev merged 3 commits intomainfrom
bholmesdev merged 3 commits intomainfrom
Conversation
This reverts commit cf62134.
🦋 Changeset detectedLatest commit: 8de3d4e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Jun 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
yieldcall to insert the renderedheadas an element. This fails forHTMLStrings (which log[Object AsyncGenerator]when left unresolved), and inserts head elements in-line best case.Testing
Docs
N/A