Skip to content

Fix ?inline and ?raw css query suffixes inlined in style tags in development#6426

Merged
matthewp merged 4 commits intomainfrom
css-inline-dev
Mar 6, 2023
Merged

Fix ?inline and ?raw css query suffixes inlined in style tags in development#6426
matthewp merged 4 commits intomainfrom
css-inline-dev

Conversation

@MoustaphaDev
Copy link
Copy Markdown
Member

@MoustaphaDev MoustaphaDev commented Mar 5, 2023

Changes

Fix #6422

Use the isBuildableCssRequest helper instead of isCssRequest so that imported css with ?raw and ?inline query suffixes aren't included in the imported styles map and inlined in style tags

Testing

  • In production:

    • Check that there's exactly one link tag
    • Check that there's no style tag
  • In development, in addition to the previously existing prod tests:

    • Check that there's no link tag
    • Check that there's exactly one style tag

Docs

Bug fix only

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 5, 2023

🦋 Changeset detected

Latest commit: 22512eb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 5, 2023
@ematipico ematipico requested a review from matthewp March 6, 2023 12:06
Copy link
Copy Markdown
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love all the new tests, thanks!

@matthewp matthewp merged commit e084485 into main Mar 6, 2023
@matthewp matthewp deleted the css-inline-dev branch March 6, 2023 13:06
@astrobot-houston astrobot-houston mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

?raw CSS is bundled in dev mode

2 participants