Conversation
|
| with: | ||
| issue-number: ${{ github.event.issue.number }} | ||
| message: | | ||
| body: | |
There was a problem hiding this comment.
This was a typo that prevented from CI commenting
| handler: async (req: IncomingMessage, res: ServerResponse) => { | ||
| const start = performance.now(); | ||
| await app.render(req); | ||
| const end = performance.now(); | ||
| res.write(end - start + ''); | ||
| res.end(); | ||
| }, |
There was a problem hiding this comment.
The main code in the @astrojs/timer integration is here. The rest are largely copied from @astrojs/node but stripped out the unneeded parts.
Yes, I think the docs needs to be elaborated more on this end. The current available ones are quite brief. I can send some followups to improve on that end in the new few days. (Or if you're interested too!) |
|
Oh crap I forgot there's a requested review for docs on this. Let me check with them real quick 😅 |
Changes
Add new
pnpm run benchmark renderCLI command, and!bench rendercomment command.Question: Is creating a private
@astrojs/timerintegration in/packages/integrations/fine? Does it affect docs generation?Example output locally:
Testing
Tested manually locally, and through https://github.com/bluwy/astro/pull/1#issuecomment-1453708161
Docs
I've added a new private
@astrojs/timerintegration that has a README. Ideally this should be kept private from users too.