Use undici's FormData for polyfilling#6413
Merged
Princesseuh merged 2 commits intomainfrom Mar 3, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 60c0eeb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
approved these changes
Mar 3, 2023
Member
natemoo-re
left a comment
There was a problem hiding this comment.
Code looks good! CI needs to be rerun, but once tests are passing this should be good to go.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Previously we used a random polyfill package for FormData, but undici actually provide this so we can use theirs instead.
Testing
Tests should pass!
Docs
Added some comments telling us which polyfills to remove in future node versions