[MDX] Improved docs for custom components#5190
Merged
bholmesdev merged 2 commits intowithastro:mainfrom Oct 25, 2022
Merged
Conversation
- whitespace at line end - blank lines around lists and code fences - casing of internal references
Incorporated all review comments from Sarah and Ben manually, because the old branch would not pass the mergeability check.
|
bholmesdev
approved these changes
Oct 25, 2022
Contributor
bholmesdev
left a comment
There was a problem hiding this comment.
Thanks for fixing this! MDXcellent contribution 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
It's just a documentation change, hence a changeset is not required.
Closes #5027
This PR replaces #5055, that would fail mergeability check for unknown reason.
Testing
It's just a documentation change, hence tests are not required.
Docs
It's just a documentation change.