Skip to content

fixing multiple doctype injections in single file#5035

Merged
matthewp merged 2 commits intowithastro:mainfrom
AirBorne04:main
Oct 10, 2022
Merged

fixing multiple doctype injections in single file#5035
matthewp merged 2 commits intowithastro:mainfrom
AirBorne04:main

Conversation

@AirBorne04
Copy link
Copy Markdown
Contributor

@AirBorne04 AirBorne04 commented Oct 10, 2022

Changes

  • limiting doctype injection to the first occurrence of html string

Testing

with the example from the solid framework (by adding the cloudflare adapter)

Docs

just a simple fix, so no doc update required.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: 59fba18

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 10, 2022
@AirBorne04
Copy link
Copy Markdown
Contributor Author

this is fixing the error from issue #5025

Copy link
Copy Markdown
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 Belter,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants