Conversation
🦋 Changeset detectedLatest commit: 0392db9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
commented
Oct 4, 2022
Comment on lines
+105
to
+118
| // Astro | ||
| const expression = getFunctionExpression(component); | ||
| if (expression) { | ||
| const slot = expression(...args); | ||
| return await renderSlot(this.#result, slot).then((res) => | ||
| res != null ? String(res) : res | ||
| ); | ||
| } | ||
| // JSX | ||
| if (typeof component === 'function') { | ||
| return await renderJSX(this.#result, component(...args)).then((res) => | ||
| res != null ? String(res) : res | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
This mixes JSX rendering into Astro.slots.render. I'm not sure if this is fine architecture-wise.
Contributor
There was a problem hiding this comment.
Yeah, that this is a bit odd but I can't think of a better way. I think it's ok for now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4826
The
Astro.slots.renderAPI only renders Astro slots, but not JSX slots. This PR updates the API to support rendering JSX slots.Testing
Copied astro-slots tests for
Astro.slots.renderfor mdx.Docs
N/A. this should be working in the first place.