feat(satteri): Add support for Prism highlighting#16969
Merged
Conversation
🦋 Changeset detectedLatest commit: 859f189 The changes in this PR will be included in the next version bump. This PR includes changesets to release 48 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
reviewed
Jun 4, 2026
Comment on lines
+6
to
+7
| /** @deprecated Renamed to `satteriHighlightPlugin` (it drives both Shiki and Prism). */ | ||
| createHighlightPlugin as satteriShikiPlugin, |
Member
There was a problem hiding this comment.
Should we have a changeset for the new API and the deprecation?
Member
Author
There was a problem hiding this comment.
It's not intended to be public I think, I hesitated and then saw that it was only us using it
Member
There was a problem hiding this comment.
Ah ok. So maybe we could add @internal too?
ematipico
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What the title says, it's easy enough, just needed hooking things up
Testing
Added / updated tests
Docs
N/A, I don't think we documented that it didn't work right now