ci: pin pnpm version#16812
Conversation
|
| "engines": { | ||
| "node": ">=22.12.0" | ||
| }, | ||
| "//": "When updating pnpm version, update merge-main-to-next workflow too", |
There was a problem hiding this comment.
Leaving a // comment here is okay. An alternative way is having a node:test unit test that reads both files and fails if versions not matching, which ensures that a PR with unmatched versions won’t get merged in the first place. However I can also understand if this seems overkill for you as merge-main-to-next isn’t one of the core workflows.
There was a problem hiding this comment.
There's no need to overkill us. This is a job we're experimenting, and we use only when doing major versions, which are rare
Changes
This PR pin the exact version used by the merge-main-to-next workflow to match the same version we use in the repository. I should fix the failures.
Testing
Merge and wait once it's triggered again
Docs
N/A