Skip to content

ci: use pinned pnpm#16791

Merged
ematipico merged 1 commit into
mainfrom
ci/use-pnpm-version
May 19, 2026
Merged

ci: use pinned pnpm#16791
ematipico merged 1 commit into
mainfrom
ci/use-pnpm-version

Conversation

@ematipico

@ematipico ematipico commented May 19, 2026

Copy link
Copy Markdown
Member

Changes

This PR fixes this failure: https://github.com/withastro/astro/actions/runs/25864427348/job/76002567202#step:7:13

It's caused by conflicts=true, which leaves possible conflict markers in package.json. Then the pnpm action comes, and tries to use the version from the manifest, which is broken.

This PR pins the pnpm version to use in the GH action

Testing

Green CI. We will see if it works after the next release.

Docs

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c59ec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the 🚨 action Modifies GitHub Actions label May 19, 2026
trueberryless
trueberryless reviewed May 19, 2026
View reviewed changes

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@ematipico ematipico merged commit 7dcf7b8 into main May 19, 2026
22 checks passed
@ematipico ematipico deleted the ci/use-pnpm-version branch May 19, 2026 15:07
@ocavue

ocavue commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ematipico Sadly this is not working. We might want to revert this PR.

See the job log below for details

https://github.com/withastro/astro/actions/runs/26157742498/job/76941398627

 Error: Multiple versions of pnpm specified:
    - version 11 in the GitHub Action config with the key "version"
    - version pnpm@11.0.9 in the package.json with the key "packageManager"
  Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION
      at readTarget (/home/runner/work/_actions/pnpm/action-setup/fc06bc1257f339d1d5d8b3a19a8cae5388b55320/dist/index.js:1:7537)
      at runSelfInstaller (/home/runner/work/_actions/pnpm/action-setup/fc06bc1257f339d1d5d8b3a19a8cae5388b55320/dist/index.js:1:6702)
      at async install (/home/runner/work/_actions/pnpm/action-setup/fc06bc1257f339d1d5d8b3a19a8cae5388b55320/dist/index.js:1:5706)
      at async runMain (/home/runner/work/_actions/pnpm/action-setup/fc06bc1257f339d1d5d8b3a19a8cae5388b55320/dist/index.js:1:2804)
      at async main (/home/runner/work/_actions/pnpm/action-setup/fc06bc1257f339d1d5d8b3a19a8cae5388b55320/dist/index.js:1:2726)
  Error: Error: Multiple versions of pnpm specified:
    - version 11 in the GitHub Action config with the key "version"
    - version pnpm@11.0.9 in the package.json with the key "packageManager"
  Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes

+1 more reviewer

@trueberryless trueberryless trueberryless left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚨 action Modifies GitHub Actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ematipico @ocavue @matthewp @trueberryless