Skip to content

fix: correctly exclude entrypoint via environments#15868

Merged
ematipico merged 1 commit intomainfrom
fix/adapter-warnings
Mar 12, 2026
Merged

fix: correctly exclude entrypoint via environments#15868
ematipico merged 1 commit intomainfrom
fix/adapter-warnings

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

Closes #15839

  • Applies noExternal using the proper configEnvrionment hook for node and netlify adapters
  • Added a missing configuration to the node adapter

Testing

Manually tested. It was the only way. I'll do a preview release too

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: 1cf9f29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico added the pr preview Apply this label to a PR to generate a preview release label Mar 12, 2026
@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) and removed pr preview Apply this label to a PR to generate a preview release labels Mar 12, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 12, 2026

npm i https://pkg.pr.new/@astrojs/cloudflare@15868
npm i https://pkg.pr.new/@astrojs/netlify@15868
npm i https://pkg.pr.new/@astrojs/node@15868

commit: 85b474c

@matthewp
Copy link
Copy Markdown
Contributor

Has this been tested with a Netlify project? When I did #15665 I recall trying environment config but thought that it wasn't being applied for some reason.

@ematipico
Copy link
Copy Markdown
Member Author

Has this been tested with a Netlify project? When I did #15665 I recall trying environment config but thought that it wasn't being applied for some reason.

Yeah I tested it and the build doesn't emit any warnings

@matthewp
Copy link
Copy Markdown
Contributor

Let me try in astro.build real quick to make sure it doesn't fail the build, which is what was happening before #15665

@matthewp
Copy link
Copy Markdown
Contributor

astro.build works. I think the difference between this and what I tried before was I was using ssr.noExternal which for whatever reason doesn't work with environment config.

@ematipico
Copy link
Copy Markdown
Member Author

astro.build works. I think the difference between this and what I tried before was I was using ssr.noExternal which for whatever reason doesn't work with environment config.

Yeah we should move away from ssr.noExternal because it doesn't cover the prerender environment

@ematipico ematipico merged commit bb2b8f5 into main Mar 12, 2026
22 checks passed
@ematipico ematipico deleted the fix/adapter-warnings branch March 12, 2026 13:50
@astrobot-houston astrobot-houston mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warns on node integration

2 participants