Skip to content

fix(assets): Missing styles in Cloudflare + MDX#15696

Merged
Princesseuh merged 5 commits intomainfrom
fix/cf-mdx-images
Feb 28, 2026
Merged

fix(assets): Missing styles in Cloudflare + MDX#15696
Princesseuh merged 5 commits intomainfrom
fix/cf-mdx-images

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh commented Feb 27, 2026

Changes

Images and styles in content in Cloudflare in MDX did not work correctly, the vite-plugin-content-assets plugin just would never run because it'd instantly fail at the beginning, the error would happens inside workerd, so it didn't crash the build but you'd just get a thousand errors during the build, and in dev the file just was wrong.

Fixes #15681 (comment)

Testing

Added a test

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 27, 2026

🦋 Changeset detected

Latest commit: f3dc8a5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 27, 2026
@Princesseuh Princesseuh marked this pull request as ready for review February 27, 2026 18:11
@matthewp
Copy link
Copy Markdown
Contributor

Needs a changeset

outDir: fileURLToPath(serverDir),
},
root: fileURLToPath(root),
logLevel: 'error',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prerenderer server is extremely spammy during the build, it didn't feel intentional?

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 27, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing fix/cf-mdx-images (f3dc8a5) with main (4db2089)

Open in CodSpeed

@Princesseuh Princesseuh merged commit a9fd221 into main Feb 28, 2026
26 of 27 checks passed
@Princesseuh Princesseuh deleted the fix/cf-mdx-images branch February 28, 2026 13:42
@CaiJimmy
Copy link
Copy Markdown

CaiJimmy commented Mar 20, 2026

Hi!

Could this bug also be present in the Markdoc + Astro component? When using UnoCSS inside a Markdoc component, I found that styles added using classlist are applied correctly, but those inside the '<style is:global>' tag are not.

I have tried to create a minimal reproducible example, but haven't succeeded yet. I'll post an update if I manage to do so.

By the way, this is only present in dev mode. In production build, styles are rendered correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro v6 <style tags in .astro components are not correctly rendered in .mdx files.

3 participants