fix: restore SVG renderability for content collection image() fields#15685
Merged
Princesseuh merged 1 commit intowithastro:mainfrom Feb 27, 2026
Merged
fix: restore SVG renderability for content collection image() fields#15685Princesseuh merged 1 commit intowithastro:mainfrom
Princesseuh merged 1 commit intowithastro:mainfrom
Conversation
SVG images in content collection image() fields were regressed to plain metadata objects by 5bc2b2c, which fixed a TLA circular-dependency deadlock by skipping SVG component creation entirely. The fix embeds the parsed SVG data (attributes and inner HTML) in the metadata at build time, then reconstructs the renderable component inside updateImageReferencesInData() in content/runtime.ts. This keeps the SVG Vite module free of server-runtime imports (preserving the TLA fix) while restoring the ability to render SVG images as inline components.
🦋 Changeset detectedLatest commit: 6f0e943 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Feb 27, 2026
Member
ematipico
left a comment
There was a problem hiding this comment.
Waiting for @Princesseuh 's approval
Princesseuh
approved these changes
Feb 27, 2026
Member
Princesseuh
left a comment
There was a problem hiding this comment.
A bit hacky perhaps, but this seems fine to me?
Contributor
Author
|
Link to RCA for the original issue, at Erika's request: #15575 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG images in content collection image() fields were regressed to plain metadata objects by 5bc2b2c, which fixed a TLA circular-dependency deadlock by skipping SVG component creation entirely.
Changes
The fix embeds the parsed SVG data (attributes and inner HTML) in the metadata at build time, then reconstructs the renderable component inside updateImageReferencesInData() in content/runtime.ts. This keeps the SVG Vite module free of server-runtime imports (preserving the TLA fix) while restoring the ability to render SVG images as inline components.
Testing
Docs