Skip to content

fix(dev): live update new pages#15337

Merged
ematipico merged 3 commits intonextfrom
fix/hmr-new-pages
Jan 30, 2026
Merged

fix(dev): live update new pages#15337
ematipico merged 3 commits intonextfrom
fix/hmr-new-pages

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

Closes #15333

I could reproduce the issue, and I definitely made a mistake when I tried to fix a similar issue before.

I vibe coded this PR, and steered the agent towards the proper fix, and trying to make as generic as possible.

We essentially send an event upon routes update, and this event is caught by our dev apps, which update the internal representation of the routes by pulling the virtual module.

Testing

Added new tests, manually tested (with and without CF adapter). CI should stay green

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 29, 2026

🦋 Changeset detected

Latest commit: fc74d0d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 29, 2026
@ematipico ematipico changed the title chore: changeset fix(dev): live update new pages Jan 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
eslint-plugin-regexp trusted-with-provenance none
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
@sveltejs/vite-plugin-svelte-inspector trusted-with-provenance provenance
@sveltejs/vite-plugin-svelte trusted-with-provenance provenance
jsdoc-type-pratt-parser trusted-with-provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 29, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing fix/hmr-new-pages (fc74d0d) with next (4592be5)1

Open in CodSpeed

Footnotes

  1. No successful run was found on next (c6f2593) during the generation of this report, so 4592be5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ematipico ematipico merged commit 7ff7b11 into next Jan 30, 2026
46 of 47 checks passed
@ematipico ematipico deleted the fix/hmr-new-pages branch January 30, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants