Skip to content

update esbuild#15193

Merged
ematipico merged 1 commit intowithastro:mainfrom
gameroman:update-esbuild
Jan 30, 2026
Merged

update esbuild#15193
ematipico merged 1 commit intowithastro:mainfrom
gameroman:update-esbuild

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

@gameroman gameroman commented Jan 13, 2026

Changes

update esbuild

Testing

existing tests should pass

Docs

not needed

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52016ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2026
@gameroman gameroman marked this pull request as ready for review January 13, 2026 21:29
@ematipico
Copy link
Copy Markdown
Member

ematipico commented Jan 14, 2026

Did you try it @gameroman , locally? Using pnpm dev, update the code and then see the changes.

@gameroman gameroman marked this pull request as draft January 14, 2026 18:21
@gameroman gameroman changed the base branch from main to next January 17, 2026 15:23
@gameroman gameroman changed the base branch from next to main January 17, 2026 15:23
@gameroman gameroman marked this pull request as ready for review January 17, 2026 17:22
@gameroman
Copy link
Copy Markdown
Contributor Author

gameroman commented Jan 17, 2026

Hi, @ematipico I just ran pnpm dev locally. Is there anything else I need to change?

@gameroman gameroman force-pushed the update-esbuild branch 4 times, most recently from caacbc7 to 8c58b9a Compare January 26, 2026 23:48
@ematipico ematipico merged commit 2bf965c into withastro:main Jan 30, 2026
25 checks passed
@gameroman gameroman deleted the update-esbuild branch February 1, 2026 01:45
@ocavue
Copy link
Copy Markdown
Contributor

ocavue commented Feb 10, 2026

It seems that this change have somehow been reverted (maybe during the merging from next to main). The esbuild version in the latest main branch is still ^0.25.0.

astro/packages/astro/package.json

Line 141 in f6ebad7

"esbuild": "^0.25.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gameroman @ematipico @ocavue