refactor(dev): use entry point to bootstrap the app#14333
Merged
ematipico merged 1 commit intofeat/environment-apifrom Sep 9, 2025
Merged
refactor(dev): use entry point to bootstrap the app#14333ematipico merged 1 commit intofeat/environment-apifrom
ematipico merged 1 commit intofeat/environment-apifrom
Conversation
|
ascorbic
reviewed
Sep 9, 2025
| const { handler } = await createExports.default(settings, controller, loader); | ||
|
|
||
| /** rebuild the route cache + manifest */ | ||
| async function rebuildManifest(path: string | null = null) { |
Contributor
There was a problem hiding this comment.
Will the routes still get updated?
Member
Author
There was a problem hiding this comment.
Yes, we have the code I just deleted in the vite plugin. And I tested it before opening the PR
ascorbic
approved these changes
Sep 9, 2025
|
|
||
| return { | ||
| handler(incomingRequest: http.IncomingMessage, incomingResponse: http.ServerResponse) { | ||
| app.handleRequest({ |
Member
Author
There was a problem hiding this comment.
No. The code we removed doesn't return anything. We keep the same logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This refactors the dev server to use an entrypoint to load the application.
Testing
The minimal example works, the react example works.
Docs