⚠️ No Changeset found

Latest commit: 01bee65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Thanks for this. We're looking to see the best way to access the binding in the image service so it can be implemented more neatly.

@penalosa, thank you for this contribution. It appears to be a fantastic addition to the adapter. I conducted an initial review of the code, and overall, it seems to be in good shape. However, I’d like to explore the possibility of enhancing its integration, which would allow us to utilize the bindings more efficiently. I’ll address this matter tomorrow morning, in European time.

On a related note, could you please provide information regarding the compatibility of the IMAGES binding with both wrangler dev and platformProxy? I’m aware that the ASSETS binding is compatible with both, iirc.

@alexanderniebuhr it's supported by wrangler dev, but not by getPlatformProxy(), it seems. I've put up a PR to Wrangler to get that fixed: cloudflare/workers-sdk#9954

As already said on Discord, after trying it myself I don't seem to have a good way to access the bindings in the transform() hook. We might be able to make that possible in the future, but for now I would like to ship this as it is. @ascorbic How do we handle this. I guess this needs a Docs PR and then does it need to wait for a minor or not?

This needs a changeset, and if possible tests

I'll take this over. I want to make this the new default option. And deprecate some other options.

@alexanderniebuhr can this PR be closed then? Thanks for handling this!

I think Alex will use this PR. I've already cherry-picked it into our environment API branch, so I'm expecting it will use this.

@penalosa yeah sorry for being a bit quite here. I will use this PR to ship this.

@alexanderniebuhr is there anything I can do to help this move along?

@alexanderniebuhr if you prefer, we can leave this as it's already in the next branch. That said, it might still be good to get it in. What do you think is outstanding to get this in?

I would like to find a way to make this as similar as possible to the next branch. For users it should not be a breaking update once we use the workerd runtime. I think the change I want here is to utilize platformProxy in dev instead of our sharp implementation. I will finalize this this week!

Okay sorry for the late reply. I have checked this once again, and I think it makes most sense to wait for v6. There is not really any good solution when running the dev server in node runtime. I'll close this PR for now. @penalosa thanks again for the initial implementation and pointing us to use this binding in the v6 version.