Fix SVG Component sprite ids#12511
Merged
ematipico merged 3 commits intowithastro:nextfrom Nov 23, 2024
Merged
Conversation
7 tasks
554a0ff to
4d6f5c4
Compare
🦋 Changeset detectedLatest commit: ddcd3c9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Nov 23, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the
idgeneration for sprite icons. The previous implementation only ever generated one id per page. This caused the first icon to be used for all icons. Instead we need to increment on each unique icon.I was able to accomplish this by checking if a component had rendered already and generating a new id if it hadn't. This now stores the full id per page.
Before
After
Testing
There were a few issues with the previous tests that I have addressed. I also updated the test to ensure that the ids are all unique which I should have asserted previously.
Docs
No docs necessary.
I can't request reviewers but wanted to tag @ematipico, @natemoo-re and @bluwy since this was related to the changes requested and committed to my previous branch. #12067 (comment)