Fix component defined in extends not rendered as Markdoc tags/nodes#11846
Merged
ematipico merged 1 commit intowithastro:mainfrom Aug 27, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 0bab683 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
approved these changes
Aug 27, 2024
11 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue where rendering Astro components as Markdoc tags and nodes when configured using the
extendsproperty would lead to an error (Unable to render [object Object]. No valid renderer was found for this file extension.).This would prevent for example Starlight users to have a configuration like this:
The issue was that when creating the component configs for used tags and nodes, the user-defined Markdoc config was used instead of the computed one that also contains the merged configurations from the
extendsproperty.Testing
I mostly duplicated the existing
test/fixtures/render-with-componentsfixture and its associatedtest/render-components.test.jstests and created a fixture where the configuration is done usingextends.Docs
This is a bug fix for a feature that does not have a specific documentation or example.