fix(types): update Astro.redirect JSDoc comment#11546
Merged
ematipico merged 2 commits intowithastro:mainfrom Jul 24, 2024
Merged
fix(types): update Astro.redirect JSDoc comment#11546ematipico merged 2 commits intowithastro:mainfrom
ematipico merged 2 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6ed812d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Jul 24, 2024
Member
ematipico
left a comment
There was a problem hiding this comment.
Thank you, could you create a changeset? We usually track docs fixes too
Member
Author
|
@ematipico Changeset added! |
ematipico
approved these changes
Jul 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update the inline documentation (JSDoc comment) for
Astro.redirect:Astro.redirectJSDoc comment is wrong #11544I haven't added a changeset since it is a small change. Should I?
Testing
No test. I only reworded a comment.
Docs
No doc needed since it does not change the behavior. However it could be a nice addition to clarify the difference between
serverandstaticwithAstro.redirect(I can post a suggestion onastro/docsseparately of this PR).