Skip to content

feat: stabilise the rewrite APIs#11542

Merged
Princesseuh merged 10 commits intomainfrom
feat/unflag-rewrites
Jul 31, 2024
Merged

feat: stabilise the rewrite APIs#11542
Princesseuh merged 10 commits intomainfrom
feat/unflag-rewrites

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

This PR makes the rewrite APIs table

Testing

The current tests should all pass

Docs

withastro/docs#8914

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: e1582d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release labels Jul 24, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

'astro': minor
---

The new rewrite APIs are deemed stable, which means that the experimental flag isn't needed anymore:
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that I have some standard guidance for writing the changeset when unflagging experimental features to get you started here!

Also, for convenience, the published URLs you might want to refer to here will be:

Astro.rewrite API reference: https://docs.astro.build/en/reference/api-reference/#astrorewrite
## Rewrites in the routing guide: https://docs.astro.build/en/guides/routing/#rewrites
## Rewriting in the middleware guide: https://docs.astro.build/en/guides/middleware/#rewriting

---

---
"astro": minor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got added twice somehow

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ematipico for this great changeset! I just had a few tiny comments for your consideration. But it's super helpful, shows people how to remove the flag, and points to the documentation! What more could I want?! 😄

@Princesseuh Princesseuh dismissed github-actions[bot]’s stale review July 31, 2024 10:37

It is Wednesday and I must merge

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs! 🥳

@Princesseuh Princesseuh merged commit 45ad326 into main Jul 31, 2024
@Princesseuh Princesseuh deleted the feat/unflag-rewrites branch July 31, 2024 10:51
@astrobot-houston astrobot-houston mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants