chore: unflag contentCollectionJsonSchema#11379
Conversation
🦋 Changeset detectedLatest commit: 930ddf8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Can this wait until 4.13? |
|
Fine for me, @ematipico just said in Discord that moving experimental flags to stable was planned for 4.12, so I tried to submit in time.. |
|
The reason to wait is that some people are on vacation that have more context on this feature and would like to get their input on whether it's missing anything or if there's any other reason to delay dropping the flag. |
sarah11918
left a comment
There was a problem hiding this comment.
Just noting that I'll come in here before 4.13 to help with the changeset!
|
Hey @alexanderniebuhr, talked a bit about this async and we were wondering:
If there's not a reason to disable it, we'd probably favor not having the option at all in config and just always doing it. |
This is the current state, the longterm goal is to improve our language-tools and extension, so users don't need to configure it manually.
It's one file for each data collection, so if you have multiple, you get multiple files
I don't see any performance issue here, but we use a 3rd party dependency to generate schemas, if that fails for any reason, a config flag would allow users to opt-out while we investigate the bug and fix it, otherwise they would need for our fix
Your call, I'm happy with both, above is just more context and not any arguments for any sides. |
|
I think everyone is in agreement here in that case, let's remove the config option and just always do this behavior. If there is an error creating the config it can fail gracefully without crashing the dev server. |
|
Glad this is making 4.13, @alexanderniebuhr ! To get you started on the changeset, here are my standard docs on what to write for unflagging an experimental feature! |
sarah11918
left a comment
There was a problem hiding this comment.
Just some quick thoughts, but otherwise looks good! Congrats on unflagging this feature! 🥳
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
bluwy
left a comment
There was a problem hiding this comment.
There seems to be many unnecessary whitespace/indent changes in this PR. Is it possible to revert them to not affect the git history?
|
I can revert them, but I got those automaticity based on the format configuration 🤔 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
It is merge day my dudes
Open questions
JsonorJSON, etc.. (cc @sarah11918 for the config naming)Changes
contentCollectioninside the config, because we might habe other options being stabilized in the future, such as cache, etc.content.tsfile, but that doesn't felt rightJsonSchemato make use of new config sectionTesting
Docs