fix: better DX for 500.astro in local development#11244
Merged
Conversation
🦋 Changeset detectedLatest commit: 10c0491 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eb322ce to
f73f190
Compare
Member
florian-lefebvre
left a comment
There was a problem hiding this comment.
I think we need a changeset for this?
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Member
|
Related docs PR withastro/docs#8495 |
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
florian-lefebvre
approved these changes
Jun 13, 2024
Member
florian-lefebvre
left a comment
There was a problem hiding this comment.
LGTM! Don't forget to update the PR I linked, specifically the part about enabling in development
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR enhance the usage of the
500.astropage when rewriting.Before, in dev mode, we were not even displaying the custom
500.astro, probably because we wanted to show the original error. However, this was causing more issues when using the rewriting, because users needed to rewrite using the500.astro, and see the results.This PR catches the error in dev mode, and renders the custom 500 if present. I also logs the original error, because that won't be visible in the default
500.astroCloses #11208
Testing
Added new test cases to test the custom
500.astroand the default 500 page (none)Docs
N/A