feat(vue): add support vue devtools options#11055
Merged
florian-lefebvre merged 8 commits intowithastro:mainfrom May 22, 2024
Merged
feat(vue): add support vue devtools options#11055florian-lefebvre merged 8 commits intowithastro:mainfrom
florian-lefebvre merged 8 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 9f1f54a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
webfansplz
reviewed
May 16, 2024
florian-lefebvre
requested changes
May 16, 2024
Member
florian-lefebvre
left a comment
There was a problem hiding this comment.
Thanks a lot! A few things:
- I added a few suggestions after @webfansplz comment
- Testing manually is definitely fine!
- Don't forget to add a changeset by running
pnpm changeset(should be a minor I think) - It will require a docs PR, feel free to ping me on the associated PR!
Contributor
Author
|
I wasn't sure about the changeset thing, other than that it should be fine now |
Member
|
Awesome thanks! I updated the changeset, can you make a docs PR? You can take inspiration from the changeset if that helps you! |
florian-lefebvre
approved these changes
May 16, 2024
Member
|
Seems like something happened in the lockfile, there's a lot of unrelated changes, could you fix that? |
Princesseuh
reviewed
May 16, 2024
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Contributor
Author
|
Thanks @florian-lefebvre for cleaning up after me 😬 |
Princesseuh
approved these changes
May 16, 2024
bluwy
approved these changes
May 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
Would probably make sense to update this section in the docs, happy to file a separate pr
/cc @withastro/maintainers-docs for feedback!
withastro/docs#8295