Merged
Conversation
🦋 Changeset detectedLatest commit: 0835949 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
approved these changes
May 13, 2024
Contributor
bholmesdev
left a comment
There was a problem hiding this comment.
Code looks right to me! Missing a spot in a test fixture looking at the unit failure
sarah11918
reviewed
May 14, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
4.8 was all about experimental... 4.9 is unflagging! 🥳
This is giving me lots of practice with changesets, in both directions, and leaving me no excuse for not writing this up as a standard guide. 😅
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
matthewp
approved these changes
May 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the experimental flag
experimental.i18nDomainsTesting
Current tests should pass
Docs
/cc @withastro/maintainers-docs for feedback!
withastro/docs#8285