Merged
Conversation
🦋 Changeset detectedLatest commit: 5fd71e7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
commented
Mar 1, 2024
Comment on lines
-45
to
+38
| const cssDeps: CompileCssResult['dependencies'][] = []; | ||
| const cssPartialCompileResults: PartialCompileCssResult[] = []; |
Member
Author
There was a problem hiding this comment.
Note: I refactored this from string[][] to { ... dependencies: string[] }[] because I needed to keep an extra isGlobal metadata whenever preprocessing is called.
| import '../components/One.astro'; | ||
| import '../components/Two.astro'; | ||
| await import('../components/Three.astro'); | ||
| await import('../components/Three.js'); |
Member
Author
There was a problem hiding this comment.
This PR caused this test to fail because the Three.astro component was imported but it's never used, hence the scoped styles in Three.astro weren't injected. Previously it was testing if the scoped styles were injected which I don't think it's quite right.
This test comes from #6176, so to stay true to what it's testing, I changed it to a .js file so that the CSS is no longer scoped.
e112e38 to
758663f
Compare
ematipico
approved these changes
Mar 4, 2024
Member
Author
|
!preview treeshake-scoped-css |
Contributor
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Unused scoped styles from Astro components are removed by checking if the main Astro module (that owns the scoped styles) is also removed/treeshaken. The PR copies some code from vitejs/vite#16058 to fix this at the meantime.
There's currently a tradeoff with this approach (vitejs/vite#16058 (comment)), but it should be better than before, and also it could be better.
Testing
Added a test. Also tested on a starlight project.
Docs
n/a. internal improvement