Skip to content

fix(i18n): move transformation outside the user schema#10169

Merged
ematipico merged 5 commits intomainfrom
fix/do-transformation-later
Feb 21, 2024
Merged

fix(i18n): move transformation outside the user schema#10169
ematipico merged 5 commits intomainfrom
fix/do-transformation-later

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

Closes PLT-1653
Closes #10157

This PR doesn't fix the bypass of the validation of the schema.

Testing

CI should pass.

I tested it locally.

Screenshot 2024-02-20 at 15 32 33

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 98c5107

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 20, 2024
@ematipico ematipico force-pushed the fix/do-transformation-later branch from 5190eaf to 2d475ce Compare February 20, 2024 15:34
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Didn’t know you’d be able to get to this so quickly 💜

Edit: Ah I see now tests are failing. Approved too soon 😁

@ematipico ematipico merged commit a462491 into main Feb 21, 2024
@ematipico ematipico deleted the fix/do-transformation-later branch February 21, 2024 07:42
@astrobot-houston astrobot-houston mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with i18n config typing

2 participants