Skip to content

qol(islands): improve hydration errors#10075

Merged
lilnasy merged 3 commits intowithastro:mainfrom
lilnasy:hydrate-error-message
Feb 13, 2024
Merged

qol(islands): improve hydration errors#10075
lilnasy merged 3 commits intowithastro:mainfrom
lilnasy:hydrate-error-message

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Feb 9, 2024

Changes

Before image
After image

Testing

Does not affect behavior.

Docs

Does not affect usage.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 9, 2024
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5aefe8e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lilnasy
Copy link
Contributor Author

lilnasy commented Feb 9, 2024

!preview island-loading-error-messages

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Snapshots have been released for the following packages:

  • astro@experimental--island-loading-error-messages
  • @astrojs/markdoc@experimental--island-loading-error-messages
Publish Log 
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--island-loading-error-messages tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-island-loading-error-messages-20240209173859) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.5 is already published on npm
🦋  warn create-astro is not being published because version 4.7.2 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.0 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.0.1 is already published on npm
🦋  info @astrojs/markdoc is being published because our local version (0.0.0-island-loading-error-messages-20240209173859) has not been published on npm
🦋  warn @astrojs/mdx is not being published because version 2.1.1 is already published on npm
🦋  warn @astrojs/node is not being published because version 8.2.0 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.4 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.1.0 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.0.10 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.0.5 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.0.3 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 7.3.0 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.8 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.2.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.2 is already published on npm
🦋  info Publishing "astro" at "0.0.0-island-loading-error-messages-20240209173859"
🦋  info Publishing "@astrojs/markdoc" at "0.0.0-island-loading-error-messages-20240209173859"
🦋  success packages published successfully:
🦋  astro@0.0.0-island-loading-error-messages-20240209173859
🦋  @astrojs/markdoc@0.0.0-island-loading-error-messages-20240209173859
🦋  Creating git tags...
🦋  New tag:  astro@0.0.0-island-loading-error-messages-20240209173859
🦋  New tag:  @astrojs/markdoc@0.0.0-island-loading-error-messages-20240209173859
Build Log 

> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 26 packages
• Remote caching enabled
::group::create-astro:build
cache hit, suppressing logs 5799893c2e029270
::endgroup::
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs 9772e0089315a60a
::endgroup::
::group::@astrojs/upgrade:build
cache hit, suppressing logs 61c9f2be46df7945
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs e10f58edf897b56b
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs 0af1d01bd65f4a97
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs 6524cb81d2c03c55
::endgroup::
::group::astro:build
cache miss, executing 647db262a3838508

> astro@0.0.0-island-loading-error-messages-20240209173859 build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> astro@0.0.0-island-loading-error-messages-20240209173859 prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> astro@0.0.0-island-loading-error-messages-20240209173859 postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 0dd5be617ca87566

> @astrojs/underscore-redirects@0.3.3 build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/rss:build
cache miss, executing da14b7e14ede26c0

> @astrojs/rss@4.0.5 build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing dde8d194b74e7919

> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing d200fc977ee4c8cd

> @astrojs/lit@4.0.1 build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing e661ecbb36365526

> @astrojs/markdoc@0.0.0-island-loading-error-messages-20240209173859 build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 8e6b3b031aff3ab5

> @astrojs/vercel@7.3.0 build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing 6d5b780f6619ec59

> @astrojs/partytown@2.0.4 build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing b108b35b7bedae64

> @astrojs/tailwind@5.1.0 build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 78e8eae032177054

> @astrojs/preact@3.1.0 build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing 3074c652b8511bef

> @astrojs/mdx@2.1.1 build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing 347e73530a6efb22

> @astrojs/alpinejs@0.4.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing 8622f8476e4f458d

> @astrojs/solid-js@4.0.1 build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing d5284d5559a8d56c

> @astrojs/react@3.0.10 build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing 8a9591ddbf470bc3

> @astrojs/node@8.2.0 build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing e53bea613b6132ce

> @astrojs/vue@4.0.8 build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 920f66d5a82f68be

> @astrojs/svelte@5.0.3 build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 2059c6dde83d05a4

> @astrojs/sitemap@3.0.5 build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    24 successful, 24 total
Cached:    6 cached, 24 total
  Time:    39.444s

@lilnasy lilnasy marked this pull request as ready for review February 12, 2024 14:23
@lilnasy lilnasy linked an issue Feb 12, 2024 that may be closed by this pull request
Safari fails to load islands: Unhandled Promise Rejection: ReferenceError: Cannot access uninitialized variable. #10055
Closed
1 task
ematipico
ematipico approved these changes Feb 12, 2024
View reviewed changes
@lilnasy lilnasy merged commit 71273ed into withastro:main Feb 13, 2024
@lilnasy lilnasy deleted the hydrate-error-message branch February 13, 2024 17:28
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

+1 more reviewer

@natemoo-re natemoo-re natemoo-re approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Safari fails to load islands: Unhandled Promise Rejection: ReferenceError: Cannot access uninitialized variable.

3 participants

@lilnasy @ematipico @natemoo-re