Skip to content

chore: move i18n routing tests#10002

Merged
ematipico merged 6 commits intomainfrom
tests/start-core-migration
Feb 7, 2024
Merged

chore: move i18n routing tests#10002
ematipico merged 6 commits intomainfrom
tests/start-core-migration

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

  • new test:node command to run only *.nodetest.js files
  • moved i18n-routing.test.js to use Node.js test runner

Warning

It seems that Node.js test runner can't very deep nested describe functions. If your test hangs, try to lift those describe functions.

Testing

CI should pass

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 6, 2024

⚠️ No Changeset found

Latest commit: 43709bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 6, 2024
@ematipico ematipico mentioned this pull request Feb 6, 2024
19 tasks
Copy link
Copy Markdown
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ematipico ematipico merged commit 9ef7917 into main Feb 7, 2024
@ematipico ematipico deleted the tests/start-core-migration branch February 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants