fix: picture fallback check (#10783)

jurajkapsz · web-flow · commit 4dbd545304d1 · 2024-04-15T16:52:39.000+08:00
diff --git a/.changeset/modern-mugs-raise.md b/.changeset/modern-mugs-raise.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes Picture component specialFormatsFallback fallback check
diff --git a/packages/astro/components/Picture.astro b/packages/astro/components/Picture.astro
@@ -45,7 +45,7 @@ let resultFallbackFormat = fallbackFormat ?? defaultFallbackFormat;
 if (
 	!fallbackFormat &&
 	isESMImportedImage(originalSrc) &&
-	originalSrc.format in specialFormatsFallback
+	(specialFormatsFallback as ReadonlyArray<string>).includes(originalSrc.format)
 ) {
 	resultFallbackFormat = originalSrc.format;
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"astro": patch
 +---
++
 +Fixes Picture component specialFormatsFallback fallback check
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ let resultFallbackFormat = fallbackFormat ?? defaultFallbackFormat;`
`45`	`45`	`if (`
`46`	`46`	`!fallbackFormat &&`
`47`	`47`	`isESMImportedImage(originalSrc) &&`
`48`		`- originalSrc.format in specialFormatsFallback`
	`48`	`+ (specialFormatsFallback as ReadonlyArray<string>).includes(originalSrc.format)`
`49`	`49`	`) {`
`50`	`50`	`resultFallbackFormat = originalSrc.format;`
`51`	`51`	`}`