Add preliminary Ingres/Vector/Actian Avalanche support#36
Add preliminary Ingres/Vector/Actian Avalanche support#36clach04 wants to merge 1 commit intowireservice:masterfrom
Conversation
Ingres, like most DBMS implementation, DDL should contain the exact length/precision and scale lengths. The defaults if omitted work but are not likely to be desired.
|
Thanks for making this and https://github.com/wireservice/csvkit available. I just used csvkit for the first time this week and whilst I was already using a similar tool, csvkit is significantly more useful and robust 👍 I opened this PR mostly to start discussion, although if it's approved that would be nice too ;-) What do you think about reversing the logic for the string length code and also the decimal precision/scale code so that they always fire irrespective of the dialect? I.e. the lines with dialect checks:
EDIT 2024-01-09 with permalinks to code: Line 197 in e0170db Line 209 in e0170db Either remove the conditional check OR replace with an alternative check if there are some backends which should not apply this logic. Which backends should this NOT be done for? sqlite doesn't need it from a DDL perspective (as sqlite essentially ignores the type spec) but I'm not sure about the SQLAlchemy dialect. I've not tested this out, I've only tested the code in the PR hence the question and the conservative code change. This works great when used with https://github.com/clach04/ingres_sa_dialect which is a (perpetually) in-progress Ingres dialect for SQLAlchemy. |
| elif dialect == 'ingres' and length > 16000: | ||
| # @see https://docs.actian.com/actianx/11.2/index.html#page/SQLRef%2FCharacter_Data_Types.htm%23 | ||
| # Could be longer but ~16K is a reasonable cut off to switch to CLOB |
There was a problem hiding this comment.
The preceding condition is "length > 21844" (which is 65,535 bytes divided by 3). The Actian docs mention 32,000 bytes, so not sure how you chose 16,000. I'll go with 10,666 (32,000 divided by 3) https://docs.actian.com/ingres/11.2/index.html#page/SQLRef/Character_Data_Types.htm
There was a problem hiding this comment.
Agreed, ~10K is a better safe/sane default. It was a while ago so like you, I cannot figure out how I chose ~16K either 😜
Thanks for taking the time to review and improve the original idea! Happy New Year 🎉
|
Added in 4f8ad30 |
Ingres, like most DBMS implementation, DDL should contain the exact
length/precision and scale lengths. The defaults if omitted work
but are not likely to be desired.