Recorder serve event transformer#3403
Merged
Merged
Conversation
RafeArnold
reviewed
Apr 29, 2026
Comment on lines
+402
to
+418
| this.id = original.id; | ||
| this.scheme = original.scheme; | ||
| this.host = original.host; | ||
| this.port = original.port; | ||
| this.pathAndQuery = original.pathAndQuery; | ||
| this.absoluteUrl = original.absoluteUrl; | ||
| this.method = original.method; | ||
| this.clientIp = original.clientIp; | ||
| this.headers = original.headers; | ||
| this.pathParams = original.pathParams; | ||
| this.cookies = original.cookies; | ||
| this.isBrowserProxyRequest = original.isBrowserProxyRequest; | ||
| this.loggedDate = original.loggedDate; | ||
| this.body = original.body; | ||
| this.multiparts = original.multiparts; | ||
| this.protocol = original.protocol; | ||
| this.formParameters = original.formParameters; |
Contributor
There was a problem hiding this comment.
we need to copy any elements of collections into new ones here. see StubMapping.Builder or RequestPattern.Builder for examples.
Contributor
There was a problem hiding this comment.
we're also missing a bunch of methods on the builder for mutating these fields
Contributor
There was a problem hiding this comment.
there's still a bunch of collections we're not copying (e.g. headers)
… empty responses are filtered out before converting to stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports transformation of serve events before they are processed by the recorder, providing another way to customise recorded output.
Intended for situations like where the the request and response body are in a format like protobuf and must be converted to JSON for use within WireMock.