Skip to content

fix: Authority.of() should not produce authorities with empty ports#3318

Merged
Mahoney merged 1 commit into
masterfrom
url-bug
Jan 28, 2026
Merged

fix: Authority.of() should not produce authorities with empty ports#3318
Mahoney merged 1 commit into
masterfrom
url-bug

Conversation

@Mahoney

@Mahoney Mahoney commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Authority.of(Host.parse("example.com"), null).toString() was wrongly
producing example.com: rather than example.com.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

`Authority.of(Host.parse("example.com"), null).toString()` was wrongly
producing `example.com:` rather than `example.com`.
@Mahoney Mahoney requested a review from a team as a code owner January 28, 2026 17:25
@Mahoney Mahoney merged commit 923b0ba into master Jan 28, 2026
5 checks passed
@Mahoney Mahoney deleted the url-bug branch January 28, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant