Don't try to parse non XML value in XPath matcher#1049
Merged
Conversation
This was referenced Dec 12, 2018
Member
|
Again, thanks for this. I'm definitely keen to improve performance in this area, and clearly given your test results you've found a potentially significant optimisation. I've added one comment against the code if you could take a quick look. |
Contributor
Author
@tomakehurst Sorry, which comment ? |
Member
|
Line 83 of |
Contributor
Author
|
@tomakehurst Sorry, I don't see it. Have you submit it? |
tomakehurst
reviewed
Jan 4, 2019
Member
|
Doh! I didn't. Have now. |
This reverts commit 0dd0117.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We try to use Wiremock for performance tests, but there is a bottleneck.
We have a mix of XML and Json stubs, and Wiremock try to parse json request in XML (see issue #776 and #652).
Or parsing data in XML is a heavy operation (CPU intensive, generate exception, ...), so don't try to parse non XML value in XPath matcher
With this simple test case:
Without my merge request:
matchingXPath on XML datas: 19137ms
matchingXPath on JSON datas: 10376ms
With my merge request:
matchingXPath on XML datas: 19278ms
matchingXPath on JSON datas: 197ms