fix: update last notified correctly, notification delay (WPB-22701)#4548
Merged
MohamadJaara merged 4 commits intodevelopfrom Feb 11, 2026
Merged
fix: update last notified correctly, notification delay (WPB-22701)#4548MohamadJaara merged 4 commits intodevelopfrom
MohamadJaara merged 4 commits intodevelopfrom
Conversation
saleniuk
approved these changes
Feb 2, 2026
MohamadJaara
reviewed
Feb 9, 2026
MohamadJaara
approved these changes
Feb 11, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4548 +/- ##
========================================
Coverage 48.66% 48.66%
========================================
Files 576 576
Lines 19952 19958 +6
Branches 3337 3338 +1
========================================
+ Hits 9709 9713 +4
- Misses 9216 9217 +1
- Partials 1027 1028 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22701
https://wearezeta.atlassian.net/browse/WPB-22701
What's new in this PR?
Issues
Application was not showing all notification when receiving a lot of messages.
Causes (Optional)
Messages for notifications are queried from the
Messagestable based on the message timestamp and conversationlast_notified_date. Last notified date was not updated correctly and some messages were filtered out by query.Notification updates are based on the
activeNotificationsproperty ofNotificationManager. New notifications for same conversation are combined with already shown notifications. When multiple notifications are shown very fastactiveNotificationsproperty does not always have up-to-date list of notifications. This is causing incorrect updates based on out-of-date list.Solutions
activeNotifications.