Skip to content

Commit 2c44321

Browse files
authored
fix: improve screen reader labels in conversations and call screens [WPB-14789] [WPB-14813] (#4580)
1 parent 3a133ea commit 2c44321

9 files changed

Lines changed: 3 additions & 9 deletions

File tree

app/src/main/kotlin/com/wire/android/ui/common/banner/SecurityClassificationBanner.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private fun SecurityClassificationBanner(
9797
Icon(
9898
painter = getIconFor(state),
9999
tint = getColorTextFor(state),
100-
contentDescription = getTextFor(state),
100+
contentDescription = null,
101101
modifier = Modifier.padding(end = dimensions().spacing8x)
102102
)
103103
Text(

app/src/main/res/values-de/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@
100100
<string name="content_description_conversation_mention_someone">Jemanden erwähnen</string>
101101
<string name="content_description_conversation_back_btn">Zurück zur Unterhaltungsliste</string>
102102
<string name="content_description_conversation_open_details_label">Unterhaltungsdetails öffnen</string>
103-
<string name="content_description_new_conversation">Nach Personen suchen oder eine neue Unterhaltung erstellen</string>
104103
<string name="content_description_send_button">Senden</string>
105104
<string name="content_description_timed_message_button">Selbstlöschende Nachrichten, Taste</string>
106105
<string name="content_description_menu_button">Hauptnavigation</string>

app/src/main/res/values-es/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
<string name="content_description_conversation_mention_someone">Mencionar a alguien</string>
108108
<string name="content_description_conversation_back_btn">Volver a la lista de conversaciones</string>
109109
<string name="content_description_conversation_open_details_label">abrir detalles de conversación</string>
110-
<string name="content_description_new_conversation">Buscar personas o crear una nueva conversación</string>
111110
<string name="content_description_back_button">Botón atrás</string>
112111
<string name="content_description_send_button">Enviar</string>
113112
<string name="content_description_timed_message_button">Botón, mensaje con autoborrado</string>

app/src/main/res/values-hu/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
<string name="content_description_conversation_mention_someone">Valaki megemlítése</string>
108108
<string name="content_description_conversation_back_btn">Vissza a beszélgetések listájához</string>
109109
<string name="content_description_conversation_open_details_label">beszélgetés részleteinek megnyitása</string>
110-
<string name="content_description_new_conversation">Személyek keresése vagy új beszélgetés létrehozása</string>
111110
<string name="content_description_back_button">Vissza gomb</string>
112111
<string name="content_description_send_button">Küldés</string>
113112
<string name="content_description_timed_message_button">Önmegsemmisítő üzenetek gomb</string>

app/src/main/res/values-ru/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@
109109
<string name="content_description_conversation_mention_someone">Упомянуть кого-нибудь</string>
110110
<string name="content_description_conversation_back_btn">Вернуться к списку бесед</string>
111111
<string name="content_description_conversation_open_details_label">открыть информацию о беседе</string>
112-
<string name="content_description_new_conversation">Поиск друзей или создание новой беседы</string>
113112
<string name="content_description_new_meeting">Начните или запланируйте новую встречу Wire</string>
114113
<string name="content_description_back_button">Кнопка назад</string>
115114
<string name="content_description_send_button">Отправить</string>

app/src/main/res/values-si/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
<string name="content_description_conversation_mention_someone">යමෙක් සඳහන් කරන්න</string>
108108
<string name="content_description_conversation_back_btn">සංවාද ලැයිස්තුවට ආපසු යන්න</string>
109109
<string name="content_description_conversation_open_details_label">සංවාද විස්තර විවෘත කරන්න</string>
110-
<string name="content_description_new_conversation">පුද්ගලයින් සොයන්න හෝ නව සංවාදයක් සාදන්න</string>
111110
<string name="content_description_back_button">ආපසු බොත්තම</string>
112111
<string name="content_description_send_button">යවන්න</string>
113112
<string name="content_description_timed_message_button">ඉබේ මැකෙන පණිවිඩ බොත්තම</string>

app/src/main/res/values-tr/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
<string name="content_description_conversation_mention_someone">Birinden bahset</string>
108108
<string name="content_description_conversation_back_btn"> Sohbet listesine geri dön</string>
109109
<string name="content_description_conversation_open_details_label">konuşma detaylarını aç</string>
110-
<string name="content_description_new_conversation">Kişileri arayın veya yeni bir sohbet oluşturun</string>
111110
<string name="content_description_back_button">Geri tuşu</string>
112111
<string name="content_description_send_button">Gönder</string>
113112
<string name="content_description_timed_message_button">Kendini yok eden iletiler, düğme</string>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
<string name="content_description_conversation_mention_someone">Mention someone</string>
117117
<string name="content_description_conversation_back_btn">Go back to conversation list</string>
118118
<string name="content_description_conversation_open_details_label">open conversation details</string>
119-
<string name="content_description_new_conversation">Search for people or create a new conversation</string>
119+
<string name="content_description_new_conversation">New. Start a new conversation</string>
120120
<string name="content_description_new_meeting">Start or schedule a new Wire Meeting</string>
121121
<string name="content_description_back_button">Back button</string>
122122
<string name="content_description_send_button">Send</string>

core/ui-common/src/main/kotlin/com/wire/android/ui/common/rowitem/EmptyListContent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,6 @@ fun EmptyListArrowFooter(modifier: Modifier = Modifier) {
7979
painter = painterResource(
8080
id = R.drawable.ic_empty_conversation_arrow
8181
),
82-
contentDescription = ""
82+
contentDescription = null
8383
)
8484
}

0 commit comments

Comments
 (0)