Wait OK after COM_QUIT#25
Merged
winterland1989 merged 1 commit intowinterland1989:masterfrom Oct 14, 2018
Merged
Conversation
Owner
|
Thanks! I'll find time to test this with the latest MySQL to confirm this behavior. BTW. Is there any documentation on the MySQL site about this behavior? |
Contributor
Author
https://dev.mysql.com/doc/internals/en/com-quit.html In particular
|
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent versions of MySQL, the server, after receiving COM_QUIT, can send an optional OK packet. But this driver close the TCP connection before reading it. So in the server LOG there are many errors like this:
There is no lost data, so the error is harmless. But it is "scaring" reading these errors in the LOG.
This patch is compatible also with older version of MySQL not sending the OK packet, like this
mysql Ver 15.1 Distrib 5.5.60-MariaDB, for Linux (x86_64) using readline 5.1Many thanks in any case for the wonderful work!